Add support to skip the logout confirmation in the auth provider #708
Conversation
|
Hi @sbidoul, |
wluyima
changed the title
wluyima
changed the title
wluyima
force-pushed
the
id_token_hint
branch
from
adc81ad
to
10faf4c
Compare
|
@wluyima This sounds useful. I'm not convinced with storing the id token on the user, if only because it won't be compatible with |
|
I'm not sure how multi tokens are handled in the auth provider, the addon currently also stores the access_token in the user table, so multi tokens would affect it too. My guess is that when a user logs out, the auth provider ends all their sessions for that particular client implying that as long I have one of the id tokens it would still end all their sessions across all tokens but I will do some research on this. I'd guess it should be possible to fetch the id_token using the token_endpoint because that's its purpose. |
wluyima
force-pushed
the
id_token_hint
branch
from
10faf4c
to
0284971
Compare
Add field to oauth provider to toggle skip logout confirmation Added tests for the skip confirmation feature Applied auto format changes Removed unused line Reduced long line
wluyima
force-pushed
the
id_token_hint
branch
from
0284971
to
2db2173
Compare
|
@sbidoul @ap-wtioit based on my last comment and the fact that this feature is disabled by default, can we merge this PR as it is? Support for multi tokens can always be implemented in a separate future issue, the assumption is that if an implementation is using multi token, then currently this feature is not for them therefore they should not turn it on. |
#707